This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Add configure option to disable TLS...


On Jan 13, 2006, David Daney <ddaney@avtrex.com> wrote:

> OK for 4.1 branch and trunk if no regressions?

Not yet.

> +Usually configure can correctly determine if TLS is supported.  In
> +cases where it guesses wrong, TLS can be disabled with
> +@option{--disable-tls}.

What if it guesses TLS support is not present, but you know it is?
As in, it performs a version test but the version in configure.in is
for a final release, whereas what you're using is a pre-release that
contains support but doesn't pass the version test?

Either you have to soften the `guesses wrong' to make it clear that it
only matches the false positives or change the code such that
--enable-tls forces TLS support on even if it doesn't look like the
assembler can take it.

> +if test x$enable_tls = xno ; then

Missing quotes around $enable_tls here.  This will barf if one passes
say --enable-tls="some string containing blanks"

-- 
Alexandre Oliva         http://www.lsd.ic.unicamp.br/~oliva/
Red Hat Compiler Engineer   aoliva@{redhat.com, gcc.gnu.org}
Free Software Evangelist  oliva@{lsd.ic.unicamp.br, gnu.org}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]