This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch 4/9] get_insn_name to gensupport.c
- From: Zack Weinberg <zackw at panix dot com>
- To: Bernd Schmidt <bernds_cb1 at t-online dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 12 Jan 2006 09:18:36 -0500
- Subject: Re: [patch 4/9] get_insn_name to gensupport.c
- References: <20060107063756.GE4437@panix.com> <43C6336A.1050609@t-online.de>
On Thu, Jan 12, 2006 at 11:46:02AM +0100, Bernd Schmidt wrote:
> > * gensupport.c: Define get_insn_name and record_insn_name here.
> > (read_md_rtx): Call record_insn_name as appropriate.
> > * genattr.c, genattrtab.c, gencodes.c, genconfig.c, genemit.c
> > * genextract.c, genflags.c, genopinit.c, genoutput.c, genpeep.c
> > * genpreds.c, genrecog.c: Don't define get_insn_name nor
> > record_insn_name. No need to call record_insn_name.
> > * Makefile.in (BUILD_SUPPORT, BUILD_PRINT): Fold into BUILD_RTL.
> > (BUILD_VARRAY): Delete.
> > (genprognormal): Rename genprogmd. Fold in all programs from
> > genprognoprint; also attrtab.
> > (build/genattrtab): Just mention genautomata.o and varray.o.
> > Reorganize a bit, add comments to make the categories clearer.
>
> This part looks ok. Incidentally, I noticed the patches aren't
> generated with diff -p which would make them a bit easier to read.
Sadly, svk cannot do diff -p, diff -c, or indeed anything other than
plain diff -u, nor does it have any capacity for spawning an external
diff.
zw