This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] libcpp deferred pragma hack (PR c++/25294)
- From: Mark Mitchell <mark at codesourcery dot com>
- To: Richard Henderson <rth at redhat dot com>
- Cc: Jakub Jelinek <jakub at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Tue, 03 Jan 2006 09:37:01 -0800
- Subject: Re: [PATCH] libcpp deferred pragma hack (PR c++/25294)
- References: <20051229113445.GX22293@devserv.devel.redhat.com> <43B457F0.3070105@codesourcery.com> <20051230184729.GA8700@redhat.com> <43B58491.5010405@codesourcery.com> <20060103165905.GA29928@redhat.com>
Richard Henderson wrote:
> On Fri, Dec 30, 2005 at 11:03:45AM -0800, Mark Mitchell wrote:
>
>>+ /* We smuggled the cpp_token->u.pragma value in an INTEGER_CST. */
>>+ token->pragma_kind = TREE_INT_CST_LOW (token->value);
>>
>>I guess we have no convenient choice, but making value a union would be
>>nicer; I hate to add places where we wrap things in trees....
>
>
> Yeah, well, changing that means changing the interface to the
> lexer; at the moment we're provided simply with a tree*, and
> not some wider structure.
>
> If you really want me to clean this up, I'd prefer to do it as
> a separate patch, since it'll affect the C front end as well.
I don't think you should in any way feel obligated to untangle this, but
if you want to do it, that would be swell. I was just griping.
Thanks,
--
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713