This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [4.0 and mainline] Fix multiplication by constant expansion
- From: Richard Henderson <rth at redhat dot com>
- To: Jan Hubicka <jh at suse dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 3 Jan 2006 08:09:09 -0800
- Subject: Re: [4.0 and mainline] Fix multiplication by constant expansion
- References: <20060101203918.GG4110@kam.mff.cuni.cz>
On Sun, Jan 01, 2006 at 09:39:18PM +0100, Jan Hubicka wrote:
> if (shiftadd_cost[mode][m] < op_cost)
> ! op_cost = shiftadd_cost[mode][m];
> else
> op_latency = add_cost[mode];
>
> new_limit.cost = best_cost.cost - op_cost;
> ! new_limit.latency = best_cost.latency - op_cost;
I don't like you mixing units like this in the last line.
> + /* Because we want to preffer combined lea over disjoint
> + operations, we are interested in sollutions having equal
Please spell-check all your comments. Lots of doubled letters.
r~