This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Add DECL_CHAIN and some other *_CHAIN



On Dec 27, 2005, at 3:24 PM, Mike Stump wrote:


On Dec 26, 2005, at 10:22 PM, Andrew Pinski wrote:
What do people think about this patch, it is very mechanical.

A couple of thoughts, first, timings for C++ (once converted) at -O0 as chain influences time more than most, and I suspect we'd want all languages bootstrapped and tested before any mid end backend code goes in, just to be sure a front end isn't misusing any part of the tree and it sure would be nice if the complier had hard types for those places that used something like DECL_CHAIN to ensure it was a decl, but, failing that, I'd hope that you could ensure that the documentation reflects the new assert. For example, take DECL_ARGUMENTS:

Also if we have don't have a decl in this place, it would ICE a little latter, this
is just checking it earlier. Also I have not changed where the chain is yet, just
the accessors and then more checking.


-- Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]