This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Re-post: DFP front-end and other changes
- From: Richard Henderson <rth at redhat dot com>
- To: Ben Elliston <bje at au1 dot ibm dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 Dec 2005 13:34:32 -0800
- Subject: Re: Re-post: DFP front-end and other changes
- References: <20051207015540.GA25978@ozlabs.au.ibm.com>
On Wed, Dec 07, 2005 at 12:55:40PM +1100, Ben Elliston wrote:
> + if (flags & CPP_N_DFLOAT)
> + copylen -= 2;
> + else
> + {
> + if ((flags & CPP_N_WIDTH) != CPP_N_MEDIUM)
> + /* Must be an F or L suffix. */
> + copylen--;
> + if (flags & CPP_N_IMAGINARY)
> + /* I or J suffix. */
> + copylen--;
> + }
The imaginary check is orthogonal to the decimal check.
> +builtin_define_decfloat_constants (void)
Why are all these values hard-coded? Seems like you should be
taking them from some header somewhere...
Otherwise it seems ok.
r~