This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Reject invalid specifiers for virtual functions


Volker Reichelt wrote:

> The following patch adds NAMED_OP to the cpp_flags in c_lex_with_flags
> when a single '0' is encountered.
> In cp_parser_pure_specifier we then check for NAMED_OP to identify a
> correct pure specifier.

> Bootstrapped and regtested on x86_64-unknown-linux-gnu.
> Ok for mainline?

I'm very excited about eliminating this long-standing wart, but I'm not
happy about the overload of NAMED_OP.  I think it would be cleaner to
create an extra flag in cpplib.h.  It looks like we've got one more bit
and I think we should use it.

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]