This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Making double precision constants work with -fsingle-precision-constant


Carlos O'Donell wrote:

> +/* Test that double precision constants are correctly handled 
> +   when code is compiled with -fsingle-precision-constant */
> +/* Origin: Carlos O'Donell <carlos@codesourcery.com> */
> +/* { dg-do run } */
> +/* { dg-options "-fsingle-precision-constant" } */
> +#include <stdio.h>

Do we actually need <stdio.h> for the test?  If not, please take it out,
so that the test will still work on freestanding systems.

The custom is to put the GCC bugzilla PR number, if any, in all of the
relevant ChangeLogs and the test case.  So, if there was an open bug for
this, then you should add that; see the current ChangeLogs for examples.

There's no need to resubmit the patch with those changes; just make
them, and check them in.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]