This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, FIX] PR25264 write to internal unit from the string itself gives wrong result.
- From: Thomas Koenig <Thomas dot Koenig at online dot de>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: Fortran List <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 11 Dec 2005 15:16:22 +0100
- Subject: Re: [PATCH, FIX] PR25264 write to internal unit from the string itself gives wrong result.
- References: <439BDBE2.3020003@verizon.net>
On Sat, Dec 10, 2005 at 11:57:22PM -0800, Jerry DeLisle wrote:
> It took a lot of trial and error to get the logic on setting the max_pos
> variable correctly. Each type of IO: files, internal units, and internal
> unit arrays, have different needs. And if its not just right, they
> clobber each other, manifested in many regressions.
> Regression tested, NIST tested.
I am really starting to hate this part of the library. The
requirements are complex (and haven't gotten simpler by the
new F90 features such as EOR and ADVANCE="NO"), the code is
getting harder and harder to understand, existing test cases
are insufficient and there are probably many more undiscovered
bugs like PR 25349 that I just found this morning.
Having said that, I can't find fault with the logic, and
regression-test worked for me too.
> OK for main TRUNK and 4.1?
OK for trunk. Because of the difficulties involved with part
of the library, I'd appreciate if you would wait a bit longer
before committing to 4.1 (say three or four days), so if this
introduces any regressions, we get more time to catch them.
Thomas