This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Rework the handling of assembler sections

Richard Sandiford wrote:
> Hans-Peter Nilsson <hp@bitrange.com> writes:

> Thanks.  Unfortunately, I don't think the patch is right.  We would
> no longer complain about .eh_frame conflicts if we happened to switch
> to our internal section after finding a conflicting decl attribute.
> (The patch even felt like a hack when I wrote last night, and in the
> cold light of day...)

I agree; given:

> I hadn't anticipated that such code would exist.  Given that it does
> (and that it's in gcc itself) I now think the best fix is to back to
> the lazy creation of eh_frame_section and exception_section.
> The patch below does this. 

The patch you've posted seems more likely to work in all situations.

> IMO, this is much cleaner than the patch I posted yesterday,
> and diffstat likes it too.  Bootstrapped & regression tested
> on i686-pc-linux-gnu.  OK to install?

OK.

Thanks,

-- 
Mark Mitchell
CodeSourcery, LLC
mark@codesourcery.com
(916) 791-8304
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]