This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] make it safe to include basic-block.h and tree-flow.h from C++
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: rafael dot espindola at gmail dot com (Rafael Espíndola)
- Cc: pinskia at physics dot uc dot edu (Andrew Pinski), gcc-patches at gcc dot gnu dot org
- Date: Fri, 9 Dec 2005 12:57:26 -0500 (EST)
- Subject: Re: [PATCH] make it safe to include basic-block.h and tree-flow.h from C++
>
> > Actually your patch is incorrect and does not fix the real issue.
> > The problem is in the struct edge_prediction.
> > struct edge_prediction GTY((chain_next ("%h.next")))
> > {
> > struct edge_prediction *next;
> > edge edge;
> > enum br_predictor predictor;
> > int probability;
> > };
> >
> > You should change the name edge to something different.
> > That will fix the issue without change all of edge in tree-flow.h.
>
> I had to change only one edge definition in tree-flow.h: The one in
> edge_prediction.
> Changing the member name is likely to be a larger patch.
Changing the name is the more correct fix.
as it will keep the code in line with the other code around it.
-- Pinski