This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
[testsuite patch]: use ilp32 in dg-skip-if target selector
- From: "Kaveh R. Ghazi" <ghazi at caipclassic dot rutgers dot edu>
- To: gcc-patches at gcc dot gnu dot org
- Cc: janis187 at us dot ibm dot com
- Date: Thu, 8 Dec 2005 22:04:00 -0500 (EST)
- Subject: [testsuite patch]: use ilp32 in dg-skip-if target selector
In a few x86 testcases, we were using a lone "i?86-*-*" target
selector for a dg-skip-if. We should really be using "ilp32" in the
cases where dg-do already restricted the test to x86, or use a target
selector of "{ i?86-*-* x86_64-*-* } && ilp32" in situations where the
testcase is checked on all targets.
Tested via mainline "make check" on i686-unknown-linux-gnu.
Okay for mainline/4.1/4.0?
Thanks,
--Kaveh
2005-12-07 Kaveh R. Ghazi <ghazi@caip.rutgers.edu>
* g++.old-deja/g++.pt/asm1.C, gcc.c-torture/compile/20000804-1.c,
gcc.target/i386/asm-3.c, gcc.target/i386/clobbers.c: Use ilp32 in
dg-skip-if target selector.
diff -rup orig/egcc-SVN20051206/gcc/testsuite/g++.old-deja/g++.pt/asm1.C egcc-SVN20051206/gcc/testsuite/g++.old-deja/g++.pt/asm1.C
--- orig/egcc-SVN20051206/gcc/testsuite/g++.old-deja/g++.pt/asm1.C 2005-11-03 10:38:49.000000000 -0500
+++ egcc-SVN20051206/gcc/testsuite/g++.old-deja/g++.pt/asm1.C 2005-12-07 09:47:44.000000000 -0500
@@ -1,6 +1,6 @@
// { dg-do assemble { target i?86-*-linux* x86_64-*-linux* } }
// We'd use ebx with -fpic/-fPIC, so skip.
-// { dg-skip-if "" { i?86-*-* } { "-fpic" "-fPIC" } { "" } }
+// { dg-skip-if "" { ilp32 } { "-fpic" "-fPIC" } { "" } }
// Origin: "Weidmann, Nicholas" <nicholas.weidmann@swx.ch>
template<int i> int foo(int v)
diff -rup orig/egcc-SVN20051206/gcc/testsuite/gcc.c-torture/compile/20000804-1.c egcc-SVN20051206/gcc/testsuite/gcc.c-torture/compile/20000804-1.c
--- orig/egcc-SVN20051206/gcc/testsuite/gcc.c-torture/compile/20000804-1.c 2005-11-28 20:00:39.000000000 -0500
+++ egcc-SVN20051206/gcc/testsuite/gcc.c-torture/compile/20000804-1.c 2005-12-07 09:51:20.000000000 -0500
@@ -1,7 +1,7 @@
/* This does not work on m68hc11 or h8300 due to the use of an asm
statement to force a 'long long' (64-bits) to go in a register. */
/* { dg-do assemble { xfail m6811-*-* m6812-*-* h8300-*-* } } */
-/* { dg-skip-if "" { i?86-*-* } { "-fpic" "-fPIC" } { "" } } */
+/* { dg-skip-if "" { { i?86-*-* x86_64-*-* } && ilp32 } { "-fpic" "-fPIC" } { "" } } */
/* Copyright (C) 2000, 2003 Free Software Foundation */
__complex__ long long f ()
diff -rup orig/egcc-SVN20051206/gcc/testsuite/gcc.target/i386/asm-3.c egcc-SVN20051206/gcc/testsuite/gcc.target/i386/asm-3.c
--- orig/egcc-SVN20051206/gcc/testsuite/gcc.target/i386/asm-3.c 2005-11-28 20:00:39.000000000 -0500
+++ egcc-SVN20051206/gcc/testsuite/gcc.target/i386/asm-3.c 2005-12-07 09:46:45.000000000 -0500
@@ -1,7 +1,7 @@
/* PR inline-asm/6806 */
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
/* { dg-options "-O2" } */
-/* { dg-skip-if "" { i?86-*-* } { "-fpic" "-fPIC" } { "" } } */
+/* { dg-skip-if "" { ilp32 } { "-fpic" "-fPIC" } { "" } } */
extern void abort (void);
diff -rup orig/egcc-SVN20051206/gcc/testsuite/gcc.target/i386/clobbers.c egcc-SVN20051206/gcc/testsuite/gcc.target/i386/clobbers.c
--- orig/egcc-SVN20051206/gcc/testsuite/gcc.target/i386/clobbers.c 2005-11-28 20:00:39.000000000 -0500
+++ egcc-SVN20051206/gcc/testsuite/gcc.target/i386/clobbers.c 2005-12-07 09:52:10.000000000 -0500
@@ -1,7 +1,7 @@
/* Test asm clobbers on x86. */
/* { dg-do run { target i?86-*-* x86_64-*-* } } */
-/* { dg-skip-if "" { i?86-*-* } { "-fpic" "-fPIC" } { "" } } */
+/* { dg-skip-if "" { ilp32 } { "-fpic" "-fPIC" } { "" } } */
extern void abort (void);