Re: [3.4 patch] Backport and fix various x86 darwin failures

[Mike Stump <mrs at apple dot com>]

On Dec 4, 2005, at 12:11 AM, Adriaan van Os wrote:
> I wonder if they are regressions, but here is the first patch  
> anyway. This fixes an obvious boostrap problem (diff kindly  
> provided by Waldek Hebisch).
>
> --- gcc/config/i386/darwin.orig.h    Sun Dec  4 08:57:17 2005
> +++ gcc/config/i386/darwin.h    Sun Dec  4 08:58:14 2005
> @@ -43,7 +43,7 @@
>
>  /* Use the following macro for any Darwin/x86-specific command- 
> line option
>     translation.  */
> -#define SUBTARGET_OPTION_TRANSLATE_TABLE
> +#define SUBTARGET_OPTION_TRANSLATE_TABLE { 0, 0 }
>
>  #define ASM_SPEC "-arch i386 \
>    %{Zforce_cpusubtype_ALL:-force_cpusubtype_ALL} \

Why not back-port from mainline:

/* Use the following macro for any Darwin/x86-specific command-line  
option
   translation.  */
#define SUBTARGET_OPTION_TRANSLATE_TABLE \
  { "", "" }

?  In general, fixed should be taken from mainline, first.  In  
addition, any bug fix for a release branch should be put onto  
mainline, first, then the next oldest release branch, and so on.


Ok, if you want to do that, provide that you also maintain the  
invariant that it also go to all release branches between the one  
you're interested in and mainline.