Re: [PATCH] New predicate covering NOP_EXPR and CONVERT_EXPR

[VÃclav Haisman <V dot Haisman at sh dot cvut dot cz>]

Richard Guenther wrote:
> For unifying handling of NOP_EXPR and CONVERT_EXPR and possibly getting
> rid of either of these, this adds a new predicate covering now both
> and in future the remaining one.
> 
> Ok for mainline?
> 
> Of course, now suggest a better name ;)
> 
> Thanks,
> Richard.
> 
> 
> 2005-12-01  Richard Guenther  <rguenther@suse.de>
> 
> 	* tree.h (NOP_CONVERSION_P): New predicate covering
> 	NOP_EXPR and CONVERT_EXPR.
> 
> Index: tree.h
> ===================================================================
> *** tree.h	(revision 107813)
> --- tree.h	(working copy)
> *************** extern const enum tree_code_class tree_c
> *** 123,128 ****
> --- 123,134 ----
>   #define COMPARISON_CLASS_P(CODE)\
>   	(TREE_CODE_CLASS (TREE_CODE (CODE)) == tcc_comparison)
>   
> + /* Nonzero if CODE represents a NOP_EXPR or CONVERT_EXPR.  */
> + 
> + #define NOP_CONVERSION_P(CODE)\
> + 	(TREE_CODE (CODE) == NOP_EXPR \
> + 	 TREE_CODE (CODE) == CONVERT_EXPR)
Isn't there some missing || or something else here?

> + 
>   /* Nonzero if CODE represents a unary arithmetic expression.  */
>   
>   #define UNARY_CLASS_P(CODE)\

Vaclav Haisman

Attachment: signature.asc
Description: OpenPGP digital signature