Re: A few more test case cleanups for -fPIC and SCO

[Jakub Jelinek <jakub at redhat dot com>]

On Wed, Nov 30, 2005 at 01:26:21PM -0800, Janis Johnson wrote:
> On Wed, Nov 30, 2005 at 08:54:09AM -0800, Kean Johnston wrote:
> > >>	* g++.dg/tls/static-1.C: Skip on SCO OpenServer 5 (no TLS support).
> > >>	* gcc.dg/tls/pr24428-2.c: Ditto.
> > >>	* gcc.dg/tls/pr24428.c: Ditto.
> > >
> > >
> > >This is IMHO the wrong way to do it.  Instead the
> > >{ dg-require-effective-target tls }
> > Other than those changes, do the others look OK to you?
> 
> I'm not finished looking through your changes, but have a couple of
> comments.  First of all, there's a check in gcc.dg/tls/tls.exp for TLS
> support.  If that check isn't detecting that your target does not
> support TLS, then the appropriate thing is to fix that check so the
> whole directory is skipped.

tls.exp just checks whether you can compile programs that use __thread.
For that you need assembler, linker and compiler support.
But as Kean wants to xfail just those 3 testcases (the runtime ones),
I guess the problem isn't compile time tests, but runtime tests that
additionally need libc/ld.so TLS support.
I think Uros' patch really solves this well, but nobody reviewed it yet.
See
http://gcc.gnu.org/ml/gcc-patches/2005-11/msg01059.html

	Jakub