This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: A few more test case cleanups for -fPIC and SCO


On Wed, Nov 30, 2005 at 08:54:09AM -0800, Kean Johnston wrote:
> >>	* g++.dg/tls/static-1.C: Skip on SCO OpenServer 5 (no TLS support).
> >>	* gcc.dg/tls/pr24428-2.c: Ditto.
> >>	* gcc.dg/tls/pr24428.c: Ditto.
> >
> >
> >This is IMHO the wrong way to do it.  Instead the
> >{ dg-require-effective-target tls }
> Other than those changes, do the others look OK to you?

I'm not finished looking through your changes, but have a couple of
comments.  First of all, there's a check in gcc.dg/tls/tls.exp for TLS
support.  If that check isn't detecting that your target does not
support TLS, then the appropriate thing is to fix that check so the
whole directory is skipped.

Your new checks are for *-*-sco3.2v5; does that cover all of the
targets it should, or is the version too specific?

Test gcc.dg/ucnid-3.c changes from XFAIL to skip for other targets;
is that on purpose?

Janis


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]