This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [ms1] Cleanup & defaults
- From: Aldy Hernandez <aldyh at redhat dot com>
- To: Nathan Sidwell <nathan at codesourcery dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, mark at codesourcery dot com, dje at watson dot ibm dot com
- Date: Wed, 30 Nov 2005 12:10:54 -0400
- Subject: Re: [ms1] Cleanup & defaults
- References: <438D8CD2.7090206@codesourcery.com>
On Wed, Nov 30, 2005 at 11:28:18AM +0000, Nathan Sidwell wrote:
> Aldy,
> Here's a patch to clean up a few things on the ms1 port.
>
> 1) There's no real need for a separate no-clobber dbnz pattern. I'm adding
> doloop instructions and the separate pattern gets in the way anyway.
>
> 2) The scratch reg lacks an early clobber. I don't think the lack of an
> early clobber causes harm in this case, because the only input reg is also
> an output reg, but the early clobber certainly indicates intent.
>
> 3) the mul instruction was gated on the now never set TARGET_MUL flag.
> I've corrected that.
>
> 4) Without any -march flag we'd generate ms1 code but fail to pick up the
> correct linker script. (I suspect this bit might change when multilibs are
> added).
>
> built & tested for ms2-elf
>
> ok for mainline & 4.1?
Ok.
And while we're at it...can we make you co-maintainer? :)
Aldy