This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Improve readability in gcc.c (execute)
- From: FX Coudert <fxcoudert at gmail dot com>
- To: patch <gcc-patches at gcc dot gnu dot org>
- Cc: reichelt at igpm dot rwth-aachen dot de
- Date: Sat, 26 Nov 2005 18:49:09 +0100
- Subject: Re: [patch] Improve readability in gcc.c (execute)
- References: <tkrat.088e577401290048@igpm.rwth-aachen.de>
Hi,
I'm not at all understanding what happens in that code, but unless I'm
really tired (and in that case, I'm sorry for interfering), your patch
is not a noop:
if (WTERMSIG (status) == SIGPIPE
&& (signal_count || greatest_status >= MIN_FATAL_STATUS))
! {
! signal_count++;
! ret_code = -1;
! }
else
#endif
In case the #if corresponding to the #endif we see here is not true,
then "signal_count++; ret_code = -1;" will never be executed, while it
was in the original code.
FX