This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][Ada] fix ada/24855
- From: Arnaud Charlet <charlet at adacore dot com>
- To: Laurent GUERBY <laurent at guerby dot net>
- Cc: Richard Kenner <kenner at vlsi1 dot ultra dot nyu dot edu>,Joel Sherrill <joel at OARcorp dot com>,gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Nov 2005 09:45:17 +0100
- Subject: Re: [PATCH][Ada] fix ada/24855
- References: <1131997246.6774.1278.camel@pc.site>
> From Joel, needed to progress on building cross arm-rtems with Ada
> enabled.
>
> Ok to commit?
Not without more explanations. Where did you test this change ?
Could you confirm that stdarg.h is guaranteed to be always available ?
Also, the placement of the include seems incorrect to me. Finally,
it would be good to give a small recap of what the problem is, so that
people do not have to go back to the PR to get this info while reviewing
your proposed change.
(Note that I have a change that will be done today which splits
raise.c into raise.c and raise-gcc.c; your patch will apply to
raise-gcc.c after my change).
Arno