This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: create preheaders for RTL loop optimizer



On Nov 13, 2005, at 1:27 PM, Steven Bosscher wrote:


On Sunday 13 November 2005 22:24, Dale Johannesen wrote:
2005-11-13 Dale Johannesen <dalej@apple.com>

         * cfghooks.c (split_block):  Copy loop_father.
         * cfgloopmanip.c (create_loops_notes):  Create preheaders.

1. This looks completely unsafe for GCC 4.1. There have been a number bug fixes for problems with or related to loop.c, and now you are proposing a patch that would change its behavior. Somehow that does not look like a good idea to me.

I won't argue with that. The bug fix part of it should go in, though.


2. Why, oh why, are people still trying to improve loop.c, instead of
   helping to replace it with something sane?

Because I have a release to get out now, not a year from now when there
is something better than loop.c available. If that has the effect of raising
the bar for its replacement, this is good. The goal is to get the best code,
right?



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]