This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libgfortran] Fix for PR24699, PR24700, PR24719]
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Jerry DeLisle <jvdelisle at verizon dot net>
- Cc: Fortran List <fortran at gcc dot gnu dot org>,gcc-patches <gcc-patches at gcc dot gnu dot org>,Paul Thomas <paulthomas2 at wanadoo dot fr>
- Date: Fri, 11 Nov 2005 20:02:20 +0100
- Subject: Re: [PATCH, libgfortran] Fix for PR24699, PR24700, PR24719]
- References: <4372B800.3050602@verizon.net>
Jerry DeLisle wrote:
> 2005-11-09 Jerry DeLisle <jvdelisle@gcc.gnu.org>
>
> PR libgfortran/24699, 24700, 24719
> * io/transfer.c (read_sf): Remove incorrect statement that was
> clearing bytes_left.
> (formatted_transfer_scalar): Add handling of end-of-record
> condition, setting values correctly to backup.
> (st_read): Initialize current_record.
There are already other people looking at the patch, I just wanted to remind
you that in previous discussion we had decided to give testcases more
expressive names than some PR number. The PR number should be in a comment in
the testcase and in the commit message, which allows one to easily find the
problem it was originally for. An expressive name OTOH gives an easy means of
quickly getting an idea what one might have broken.
Cheers,
- Tobi