This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't use slowcompare method unconditionally
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: paolo dot bonzini at lu dot unisi dot ch (Paolo Bonzini)
- Cc: pinskia at physics dot uc dot edu (Andrew Pinski), gcc-patches at gcc dot gnu dot org, jakub at redhat dot com (Jakub Jelinek), kcook at gcc dot gnu dot org
- Date: Wed, 9 Nov 2005 11:44:04 -0500 (EST)
- Subject: Re: [PATCH] Don't use slowcompare method unconditionally
>
>
> >>So wouldn't defining a POSIX_TAIL="_POSIX2_VERSION=199506 tail" and
> >>using then using $(POSIX_TAIL) +16c be a more complete idea for bith
> >>broken and non-broken coreutils?
> >
> > Or better yet, error out with a broken coreutils which already happens
> > so getting them (coreutils maintainers) to fix this instead of hacking
> > already working sources is a better fix.
>
> No need to vent. Just using
>
> _POSIX2_VERSION=199506 tail +16c foobar
>
> in the slowcompare target is the Simplest Possible Thing To Do, and it
> cannot be harmful.
Yes it can do harm, first it changes behavior which changing from an older
version of POSIX to a newer should not.
This again is a bug in coreutils and really needs to be fixed there.
How many times does this has to be discussed here on GCC for a coreutils
bug?
-- Pinski