This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch to gcc_update to include revision number in LAST_UPDATED


David Edelsohn <dje@watson.ibm.com> wrote:

> The command svnversion stats every file in the check out, which
> increases the time to run gcc_update substantially.
>
> How about
>
> echo "`TZ=UTC date` (`svn info | grep Revision`)"
>
> ?


For gcc_update/LAST_UDPATED, this is enough I believe.

But there is one important property which svnversion gives you, while your
solution does not: whether the working copy is modified or not. I would like to
get to the point where version.c is recomputed at build time by svnversion,
because:

1) We would know for sure whether the testresult we see in gcc-testresult come
from a pristine copy, or as a result of a test with some patch applied. I find
irritating that I need to know by heart which testers are automatic (and those
can be used as baseline) and which are casual (and thus could just be testing
some local modification).

2) In bug reports, if gcc -v says "105678M" (note the 'M'), we would know there
are local patches in the tree, which is a typical msitake done even by
experienced GCC maintainers. "Hey bootstrap is broken", "not for me", "not for
me", "not here", "ah sorry, I had local patches".

Giovanni Bajo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]