This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA/RFC] PR24230, problems when casting AltiVec constants

David Edelsohn wrote:

	The patch looks like a good cleanup.  It will take some more time
to review, but I noticed the following:

+  if (vspltis_constant (op, step, copies))
+    return true;
+
+  return false;

Isn't this

return vspltis_constant (op, step, copies);


Yes, I just wanted to replicate the same pattern as the above copies. With an extra comment, it may look like this:

 if (vspltis_constant (op, step, copies))
   return true;

 /* No more possibilities.  Add code here if there are other
    constants that you want to make `easy'.  */
 return false;

Paolo

ps: the rs6000.c changes look much better in context diff format

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]