This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, fortran] PR19292 - g77 features missing or broken: PR18737and PR21565


Tobi,

There are a lot of places where we call gfc_set_default_type with error_flag =
0, are you sure that issuing the errors is correct in all these places? If
that's not certain, a safer approach would be changing the callsite in
resolve.c to only set error_flag == 0 if the symbol is an intrinsic function.


One thing that I am sure of is that a failure, anywhere, to find a default type for an external symbol is always an error. I am not so sure that doing it your way round is always correct. However, I will retire for a few quiet moments this evening to contemplate the issue. It's time I updated the Doxygen documentation isn't it?

2] PR21565: Add to check_conflict the constraint that a namelist object
cannot be in block data.



This is of course ok.


Thanks

Paul


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]