This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR fortran/18157 pointer to user-defined type and
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: tobias dot schlueter at physik dot uni-muenchen dot de (Tobias Schlüter)
- Cc: pinskia at physics dot uc dot edu (Andrew Pinski), gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Tue, 25 Oct 2005 14:16:48 -0400 (EDT)
- Subject: Re: [PATCH] Fix PR fortran/18157 pointer to user-defined type and
> Well, strictly speaking the third testcase doesn't need a temporary either, as
> the loop can be reversed.
I filed PR 24524 for that.
>
> I have two comments:
>
> > ChangeLog:
> > * trans-array.c (gfc_conv_resolve_dependencies): Use the correct
> > type of the temparory array.
> ^^^^^^^^^
> s/temparory/temporary/ here and everywhere else.
Woops, stupid me typing without spell checking my email (since
I am not using my Mac as it is broken I don't get feedback right away for
a wrongly spelled word).
> > * trans-expr.c (gfc_trans_assignment): Pass lss instead of lss_section
> > to gfc_conv_resolve_dependencies to get the correct type.
>
> You need the same change in gfc_trans_where_assign as well (+ a corresponding
> testcase).
Will look into that.
> Otherwise this is ok.
Thanks,
Andrew