This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR

From: Andrew Haley <aph at redhat dot com>
To: Eric Botcazou <ebotcazou at adacore dot com>
Cc: Paolo Bonzini <paolo dot bonzini at lu dot unisi dot ch>, gcc-patches at gcc dot gnu dot org
Date: Thu, 20 Oct 2005 18:27:14 +0100
Subject: Re: [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR
References: <43552D67.4040301@lu.unisi.ch><200510201903.53711.ebotcazou@adacore.com><4357CE40.80101@lu.unisi.ch><200510201922.35163.ebotcazou@adacore.com>

Eric Botcazou writes:
 > > Could you please test changing
 > >
 > >   if (BRANCH_COST >= 4)
 > >
 > > to
 > >
 > >   if (BRANCH_COST >= 4
 > >
 > >      || TREE_SIDE_EFFECTS (TREE_OPERAND (exp, 1)))
 > >
 > > as in the attached patch (which is untested, but should apply to 4.1 and
 > > 4.0 and, with some fuzz, to 3.4 as well)?
 > 
 > I will, but I'd be quite wary of relying exclusively on the side-effects bit.  
 > I think that's far too dangerous for Ada at this point on release branches; 
 > at a very minimum, please revert the change on the 3.4 branch.

I'm wary too.  I think all trapping arithmetic in Java should have
TREE_SIDE_EFFECTS set, but I couldn't swear to it.

Andrew.

References:
- [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR
  - From: Paolo Bonzini
- Re: [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR
  - From: Eric Botcazou
- Re: [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR
  - From: Paolo Bonzini
- Re: [4.1/4.0/3.4] fix pr19672 by tuning expansion of TRUTH_{AND,OR}_EXPR
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]