Re: [patch,gfortran] PR 22273: LEN() of INTENT(OUT) dummy

[Erik Edelmann <erik dot edelmann at iki dot fi>]

On Fri, Oct 14, 2005 at 01:52:01PM +0300, Erik Edelmann wrote:
> On Fri, Oct 14, 2005 at 12:12:46PM +0200, Tobias Schlüter wrote:
> > Erik Edelmann wrote:
> > > Is there any reason why the len() intrinsic is excluded from the
> > > inquiry function list in expr.c/check_inquiry()?  By including it
> > > (see attached patch) we would fix PR 22273.
> > 
> > There are only two reasons I can think of: either to raise awareness of the
> > FIXME comment :) or because this code was originally only intended for numeric
> > inquiry functions, as their value can always be evaluated at compile time.
> > But since we also allow array inquiry functions (lbound etc.), I think this is
> > ok, once you update the comment further down in check_inquiry.
> 
> Ok, here's an updated patch with fixed comment (I removed the
> word 'numeric', and reformatted it).  Please commit if OK.
> 
> 
>         Erik
> 
> 
> 2005-10-14  Erik Edelmann  <erik.edelmann@iki.fi>
> 
>         PR 22273
>         * expr.c (check_inquiry): Add "len" to inquiry_function
>           and update comment.

Damn. Of course I forgot to attach the patch.


        Erik

Attachment: 22273.diff
Description: Text document