This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR 23439/23440, two alternatives
- From: Ian Lance Taylor <ian at airs dot com>
- To: Volker Reichelt <reichelt at igpm dot rwth-aachen dot de>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: 06 Oct 2005 13:38:03 -0700
- Subject: Re: [patch] Fix PR 23439/23440, two alternatives
- References: <tkrat.9232ba2f2ec74bff@igpm.rwth-aachen.de>
Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:
> The first patch fixes this by returning early from annotate_with_file_line,
> if no filename is given. It also clears an already present annotation
> to match the behavior in the MAPPED_LOCATION case (according to Ian's
> comment).
>
> The second version changes the frontends: It modifies unknown_location
> and its C++ counterpart to include a dummy filename instead of a
> NULL-pointer.
>
> A testcase for each frontend is also included.
>
> A final decision on which approach is the better one was never reached,
> so I'm reposting updated versions of the patches.
>
> Both versions were bootstrapped and regtested on i686-pc-linux-gnu.
> Which version is the preferred one?
> OK for mainline and 4.0 branch?
I prefer the second version, but only the frontend maintainers can
approve it.
Ian