This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Fix PR c++/23965: Bogus error message with "<type error>"
- From: Volker Reichelt <reichelt at igpm dot rwth-aachen dot de>
- To: Gabriel Dos Reis <gdr at integrable-solutions dot net>
- Cc: Mark Mitchell <mark at codesourcery dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 06 Oct 2005 16:08:30 +0200 (CEST)
- Subject: Re: [patch] Fix PR c++/23965: Bogus error message with "<type error>"
- References: <tkrat.501adc4318b73c0b@igpm.rwth-aachen.de><4330162D.2000408@codesourcery.com><tkrat.cab5ba050efee2e4@igpm.rwth-aachen.de><m3psqi4y0f.fsf@uniton.integrable-solutions.net>
On 6 Oct, Gabriel Dos Reis wrote:
> Volker Reichelt <reichelt@igpm.rwth-aachen.de> writes:
> | Hi Mark, hi Gaby,
> |
> | unfortunately I managed to misread the above suggestion and added
> |
> | if (arg == error_mark_node || error_operand_p (arg))
> |
> | instead of just
> |
> | if (error_operand_p (arg))
> |
> | to the 3.4 branch and mainline. This results in a redundant check.
> | (I applied the correct version to the 4.0 branch.)
> |
> | The patch below fixes that.
> | Bootstrapped and regtested on i686-pc-linux-gnu.
> |
> | Ok for mainline? Or should I wait until the semi-freeze is over?
> |
> | Ok for the 3.4 branch? Or should I wait until after the 3.4.5 release?
>
> It it makes it into 4.0.x then you may apply it to 3.4.x.
The suboptimal version never made it into the 4.0 branch - as the
branch was frozen then. After the branch reopend I committed the
corrected version to the 4.0 branch. In this sense the 4.0 branch
has the patch.
Applied to mainline and 3.4 branch.
> Thanks,
>
> -- Gaby