This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Fixincludes patch for bug 23139


Gabriel Dos Reis wrote:
"Joseph S. Myers" <joseph@codesourcery.com> writes:

| This patch works around bug 23139 (errors from use of HUGE_VAL from
| old glibc headers in C++ with -pedantic) by fixincluding the problem
| definitions. It adds a test to ensure that whatever subsequent fixes
| there may be, HUGE_VAL remains usable (and with the correct value)
| from C++ with -pedantic. It also makes corresponding fixes and
| conditional tests for HUGE_VALF and HUGE_VALL.
| | There should still be more thorough fixes for the various underlying
| diagnostic issues, but this patch provides a fix now for 4.0 and 4.1
| (which could also be backported to 3.4).


I ran into similar bug when I was converting GCC to compile with a
C++ compiler.  However I think I underestimated the overall impact.
If you're willing to prepare a patch for 3.4.x -- after approval and
testing on 4.0.x for some time, then I'm willing to accept it.

It looks pretty reasonable to me. I would suggest applying to all active branches. - Bruce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]