This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [4.2 PATCH]: PRs 6123 & 18382, centralize defining __PIC__/__pic__

 > On Wed, Sep 07, 2005 at 04:01:51PM -0700, Mike Stump wrote:
 > > On Sep 7, 2005, at 10:34 AM, Richard Henderson wrote:
 > > >>IMHO, consistency is better than the jumble of (undocumented!!)
 > > >>mechanisms we have now.
 > > >
 > > >Hum.  Well, I guess with enough warning posted in the release
 > > >notes, this *might* be ok.
 > > 
 > > I too think the patch is ok.  The chances are low that the m68k  
 > > people are going to care much, and if they do, we can solicit more  
 > > target control.  Do we have any m68k folks that want to let us know  
 > > if they don't like the proposed plan?
 > 
 >   AFAICT, on m68k only linux had __pic__/__PIC__ defines before
 >   3.4. The current behaviour was introduced with 3.4, but the linux
 >   configuration kept its way dealing with these macros in specs. Thus
 >   I think there won't break much if anything at all by this
 >   change. (Now one has to test the value of __fpic__ to distinguish
 >   the different modes). [...]
 >   Gunther

Thanks for your comments.  Rth subsequently approved the patch
offline, so I'll install it after we branch 4.1.

		Thanks,
		--Kaveh
--
Kaveh R. Ghazi			ghazi@caip.rutgers.edu
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]