This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR c++/23180 (4.1 regression)


On Sep 8, 2005, at 3:24 PM, Ian Lance Taylor wrote:

Josh Conner <jconner@apple.com> writes:


2005-09-08 Josh Conner <jconner@apple.com>

         PR c++/23180
         * expr.c (expand_expr_addr_expr_1): Don't invoke
         expand_simple_binop if addr and offset are both constants.


What if you just change line 6341 from
      if (modifier == EXPAND_SUM)
to
      if (modifier == EXPAND_SUM || modifier == EXPAND_INITIALIZER)
?

This alternative approach appears to work for the example given in the PR. I'll re-start testing.

(As an aside, write
    else if
not
    else
    if
)

OK - thanks.

(As another aside, please make the MIME type of your attachments
text/plain or text/x-patch.  I see you are doing attachments using the
dreaded Apple Mail; I believe that one way to get an acceptable MIME
type is to name the file with an extension of ".txt".)

OK - thanks again.

- Josh

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]