This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] delegitimize pic constructs in more places (PR rtl-optimization/23098)


On Sat, Sep 03, 2005 at 06:19:38AM -0400, Jakub Jelinek wrote:
> So I really don't know what exactly should rtl_for_decl_location be
> doing for delegitimization.

revision 1.365
date: 2002/04/16 06:18:37;  author: jakub;  state: Exp;  lines: +10 -1
        PR target/6303
        * dwarf2out.c (rtl_for_decl_location): Call ASM_SIMPLIFY_DWARF_ADDR
        before returning.
        * config/i386/i386.c (i386_simplify_dwarf_addr): Simplify @GOT only
        when inside of MEM by eliminating the indirection too.
        * config/s390/s390.h (ASM_SIMPLIFY_DWARF_ADDR): Define.
        * config/s390/s390.c (s390_simplify_dwarf_addr): New.
        * config/s390/s390-protos.h (s390_simplify_dwarf_addr): Add
        prototype.


> I think the only outstanding question is
> if there should be a separate predicate for constant pool references,
> but it should IMHO cover all cases that avoid_constant_pool_reference
> checks for (e.g. even the mode and offset into the constant), so
> either code should just use the
> avoid_constant_pool_reference (x) != x
> predicate directly, or there should be a tiny function that does the same.

A tiny function would be a bit less odd than that as a bare expression.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]