Re: [PATCH] Testsuite: fix several ARM tests

[Josh Conner <jconner at apple dot com>]

On Aug 31, 2005, at 3:15 AM, Richard Earnshaw wrote:

> On Tue, 2005-08-30 at 19:17, Josh Conner wrote:
>
> > The following g++.dg tests fail on arm-none-elf, all because of the
> > default behavior of padding structure members to 32-bit boundaries:
> >
> >    * ext/packed8.C (depends on packed struct having a different
> > layout from an unpacked struct)
> >    * init/array16.C (depends on an array of ~4M classes containing
> > only a single char each fitting within another 5M array)
> >    * other/crash-4.C (depends on packed struct having a different
> > layout from an unpacked struct)
> >
> > The attached patch addresses these issues by adding the -mstructure-
> > size-boundary=8 option to the command-line for arm-*-* targets.
> > Verified that this patch addresses the problems on arm-none-elf, and
> > on i686-pc-linux-gnu that the tests work as before.
> >
> > OK for mainline?
> >
> > - Josh
> >
> > 2005-08-30  Josh Conner  <jconner@apple.com>
> >
> >          * g++.dg/ext/packed8.C: Add -mstructure-size-boundary=8 to
> >          command-line options for arm-*-* targets.
> >          * g++.dg/init/array16.C: Likewise.
> >          * g++.dg/other/crash-4.C: Likewise.
>
> Grr, yes, OK.
>
> I wonder if it should be noted that these tests make implicit
> assumptions about structure layout.
>
> R.

Does this patch adequately address your concerns?

- Josh

Attachment: mssb2.patch
Description: Binary data