This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Testsuite: fix several ARM tests
- From: Richard Earnshaw <rearnsha at gcc dot gnu dot org>
- To: Josh Conner <jconner at apple dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 31 Aug 2005 11:15:07 +0100
- Subject: Re: [PATCH] Testsuite: fix several ARM tests
- References: <F0554897-41CA-45AB-B902-E26F31DAE5DD@apple.com>
On Tue, 2005-08-30 at 19:17, Josh Conner wrote:
> The following g++.dg tests fail on arm-none-elf, all because of the
> default behavior of padding structure members to 32-bit boundaries:
>
> * ext/packed8.C (depends on packed struct having a different
> layout from an unpacked struct)
> * init/array16.C (depends on an array of ~4M classes containing
> only a single char each fitting within another 5M array)
> * other/crash-4.C (depends on packed struct having a different
> layout from an unpacked struct)
>
> The attached patch addresses these issues by adding the -mstructure-
> size-boundary=8 option to the command-line for arm-*-* targets.
> Verified that this patch addresses the problems on arm-none-elf, and
> on i686-pc-linux-gnu that the tests work as before.
>
> OK for mainline?
>
> - Josh
>
> 2005-08-30 Josh Conner <jconner@apple.com>
>
> * g++.dg/ext/packed8.C: Add -mstructure-size-boundary=8 to
> command-line options for arm-*-* targets.
> * g++.dg/init/array16.C: Likewise.
> * g++.dg/other/crash-4.C: Likewise.
Grr, yes, OK.
I wonder if it should be noted that these tests make implicit
assumptions about structure layout.
R.