This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Generalize insert_insn_end_bb()


> In fact, Kenny did this for his prespilling code, because of the need to
> insert at begin/end of bb's. I think he threw it in cfgrtl.c
> I've pasted his versions, which only take two parameters, which is what
> one would expect.  IMHO, a new 5 parameter function that requires
> sbitmaps, etc, just to insert instructions in basic blocks would never
> be used :)

This makes sense to me.

Can I use these functions?
Will they be inserted to mainline?

Isn't there a need to change the code of mode switching to use them?

What about the other problems that my patch handles (the redundant
increment of gcse_create_count and the assertions that are never used)?


Leehod.



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]