Re: [v3] libstdc++/20534 contd contd

[Benjamin Kosnik <benjamin dot kosnik at gmail dot com>]

Hey Paolo. Good to see you back. 

> Well, maybe it will but on the other hand we are inlining a very rarely
> called and performance non-critical function in a *lot* of places!
> Agreed, in debug mode we don't care much about code quality issues, but
> the bloat can certainly be very high: there are quite a few very small
> functions in the containers that can very easily grow 2-3 times bigger!

I agree, codegen and size issues are not the highest priority for the
debug mode in general, as you say. 

In the spirit of adventure, I have measured this.
I've compiled all of 23/24/25 test cases with debug mode support on,
with cvs and the patch. The sizes are attached. This is done with small
modifications to the check-compile routines, which I will check in
shortly.

You'll find the size difference to be minimal to non-existent (I didn't
see any difference). I believe this should satisfy your objection.

Keep in mind there is a price to pay for every export for the non-debug
mode library. Keeping the export list as small as possible is always a
good idea.

> What about keeping the current approach in mainline and using the new,
> less invasive, one in the 4_0-branch only? Or, as far as I'm concerned,
> we can as well *not* have the assert removal in 4_0-branch...

Whoops, sorry for the confusion.  I'm not porting the assert removal to
gcc-4_0-branch. I consider that work not quite done yet based on
some open bugzilla reports for mainline. The exports for compiling
without extern template are a precursor to this work, but not it. I'm
hoping to get this in, finish up with the rest of Jakub patch review,
and then work on the bugzilla issues. Sound like a plan?

We either move all or none of GLIBCX_3.4.5 to gcc-4_0-branch, we can't
just move some of it and have mainline and the branch differ. I'd like
to just do this cleanup and move it all.

By doing this, we can easily move all of GLIBCXX_3.4.5 exports to
gcc-4_0-branch. Seems like a good idea to me: it will ease maintenance
for this branch in the future.

OK?

-benjamin

Attachment: cvs.out
Description: Text document

Attachment: patch.out
Description: Text document