This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFA:fix PR middle-end/23467
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: joern dot rennecke at st dot com (Joern RENNECKE)
- Cc: pinskia at physics dot uc dot edu (Andrew Pinski), gcc-patches at gcc dot gnu dot org
- Date: Thu, 25 Aug 2005 08:36:04 -0400 (EDT)
- Subject: Re: RFA:fix PR middle-end/23467
>
> Andrew Pinski wrote:
>
> >
> > On Aug 19, 2005, at 8:10 AM, Joern RENNECKE wrote:
> >
> >> Joern Rennecke wrote:
> >>
> >>> 2005-08-18 J"orn Rennecke <joern.rennecke@st.com>
> >>>
> >>> gcc:
> >>> PR middle-end/23467
> >>> * stor-layout.c (finalize_type_size): Dont override
> >>> existing alignment with a smaller alignment from the mode.
> >>> testsuite:
> >>> PR middle-end/23467
> >>> * gcc.c-torture/execute/pr23467.c: New test.
> >>>
> >> P.S.: bootstrapped & regtested on i686-pc-linux-gnu native &
> >> regtested on i686-pc-linux-gnu X sh-elf.
> >
> >
> > Are you sure you tested this patch because I am getting failures in
> > libjava
> > which was caused by this patch. Confirmed by reverting the patch and
> > rebuilding
> > all of libjava.
>
> on i686 native I did a make bootstrap / make compare / make check-gcc
> from the toplevel of a unified tree.
> make check is not really suitable because it tests to many components of
> bfd / binutils / gdb etc. so that it
> would take too much time and disk space. I'll try an additional make
> check-target-libjava .
Then you did not "bootstrapped & regtested" at all because the target
libraries were not tested. libjava has the java testsuite because gcj
really cannot run without ligcj. Also libstdc++ is not well tested
with your method either.
-- Pinski