This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] fix overlapping enum namespace
- From: Andrew Pinski <pinskia at physics dot uc dot edu>
- To: echristo at apple dot com (Eric Christopher)
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Fri, 19 Aug 2005 01:59:52 -0400 (EDT)
- Subject: Re: [patch] fix overlapping enum namespace
>
>
> --Apple-Mail-2-94707409
> Content-Transfer-Encoding: 7bit
> Content-Type: text/plain;
> charset=US-ASCII;
> delsp=yes;
> format=flowed
>
> optabs.h and c-common.h both use CTI_ for their index enums. While
> doing some illicit file including while working on something else I
> came across the multiple definitions. This changes all of the uses in
> optabs to COI (convert_optab_index) and leaves CTI (c-tree index) alone.
>
> Tested on powerpc-darwin, no regressions. Probably obvious, but I'll
> ask for approval in case anyone has any complaints.
>
> OK?
Yes this would be causing an ODR violation with C++ please leave it there,
just for that reason alone.
-- Pinski