This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch]: Fix PR testsuite/23239
- From: James E Wilson <wilson at specifix dot com>
- To: John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 18 Aug 2005 17:33:32 -0700
- Subject: Re: [patch]: Fix PR testsuite/23239
- References: <200508141927.j7EJR7Ui014303@hiauly1.hia.nrc.ca>
John David Anglin wrote:
> PR testsuite/23239
> * gcc.dg/tree-prof/val-prof-5.c: Fix scan-tree-dump regexp.
You didn't explain why there was a problem here, and I was curious, so I
checked. It turns out that the PA port defines the undocumented
ASM_PN_FORMAT macro, and thus we need a different regexp here to match
what the PA port emits. In general, this is a losing solution, since
ASM_PN_FORMAT can have an arbitrary definition, and thus we may need
future regexp changes here. In fact, if there were any ports that
defined both NO_DOT_IN_LABELS and NO_DOLLAR_IN_LABELS then we would
already have a problem, because the default value of ASM_PN_FORMAT in
that case won't match either the existing regexp or your new one. Since
elfos.h defines NO_DOLLAR_IN_LABELS, it looks like a few ports defining
NO_DOT_IN_LABELS like mmix-elf and xtensa-elf are still broken. We
probably could change this no-dot no-dollar value in defaults.h to match
the one in the pa.h file, which is also used by a number of other
targets. This plus your fix should make this testcase work for all targets.
Anyways, your fix is certainly OK, it improves the situation as it at
least makes this testcase work on PA and a few other targets.
--
Jim Wilson, GNU Tools Support, http://www.specifix.com