This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFC][PATCH] -d_lines
- From: Tobias Schlüter <tobias dot schlueter at physik dot uni-muenchen dot de>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: Bernhard Fischer <rep dot nop at aon dot at>, fortran at gcc dot gnu dot org,patch <gcc-patches at gcc dot gnu dot org>,Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Date: Wed, 17 Aug 2005 22:10:21 +0200
- Subject: Re: [RFC][PATCH] -d_lines
- References: <20050816232145.GR15261@aon.at> <43039612.3000404@physik.uni-muenchen.de> <bbf22521a474f1a0e08244bd16c83933@physics.uc.edu>
Andrew Pinski wrote:
> On Aug 17, 2005, at 3:54 PM, Tobias Schlüter wrote:
>
>
>>+ /* Find end of file name. */
>>+ i = 0;
>>+ while ((i < PATH_MAX) && (filename[i] != '\0'))
>>+ i++;
>>+
>>+ /* Improperly terminated or too-long filename. */
>>+ if (i == PATH_MAX)
>>+ return FORM_UNKNOWN;
>
>
> You are introducing a depend on PATH_MAX which is not correct.
> If the filename is not ending in 0, well let the compiler crash
> because there is something wrong inside the compiler.
>
> All uses of PATH_MAX should be removed from the fortran front-end.
> I thought there was a patch to do just that.
Yes, but it looks like it wasn't committed before I copy'n'pasted that chunk.
Thanks for spotting this. I'll combine this with Steve's patch from
http://gcc.gnu.org/ml/fortran/2005-08/msg00009.html, which I had approved before.
Ok?
- Tobi