This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Patch: fix PR java/23300
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 16 Aug 2005 17:03:04 +0100
- Subject: Re: Patch: fix PR java/23300
- References: <m3wtmnrxkn.fsf@localhost.localdomain>
Tom Tromey writes:
> This patch fixes PR java/23300.
>
> The immediate cause of the crash is fixed by the expr.c patch. We
> were generating an otable reference when DECL_FIELD_OFFSET was 0.
> But, it makes no sense to do this, because if !flag_indirect_dispatch,
> we will end up with bogus trees.
>
> The ultimate cause of the bug turned out to be a name resolution
> failure. I fixed this by arranging to pass the class' outer class (if
> any) to do_resolve_class in maybe_layout_super_class.
>
> Tested on x86 FC4, including mauve and jacks. Ok?
>
> Tom
>
> Index: ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> PR java/23300.
> * expr.c (build_field_ref): Don't generate otable reference when
> DECL_FIELD_OFFSET is 0.
> * class.c (maybe_layout_super_class): Pass outer class to
> do_resolve_class.
OK.
Andrew.