This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Fix PR23320

From: Sebastian Pop <sebastian dot pop at cri dot ensmp dot fr>
To: Ira Rosen <IRAR at il dot ibm dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Sat, 13 Aug 2005 00:50:38 +0200
Subject: Re: [patch] Fix PR23320
References: <OF0498CF95.B730122D-ONC225705A.003EC519-C225705A.0045900C@il.ibm.com>

Ira Rosen wrote:
> 
>       * tree-data-ref.c (base_addr_differ_p): Add comment. Check data-refs'
>       types instead of base object nullness. Add check for pointer type
>       data-refs before first location comparison. Remove assert.
> 

This is ok, thanks.  There is still a minor typo:

!    3. else if (DRA and DRA are represented differently or 2. fails)
!           only try to prove that the bases are surely different

you have to replace "DRA and DRA" with "DRA and DRB".  This occurs
twice in the patch.

References:
- [patch] Fix PR23320
  - From: Ira Rosen

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]