This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR23230 - wrong code generated in inner class

Ranjit Mathew wrote:

Regression tests for gcj PRs should go in libjava/testsuite, so please
include the regression test when you check in your patch. Tests that are
actually in the gcc tree are more likely to get run by "random gcc
hackers", so its good to have as many tests in there as possible.

Of course, if no test for this currently exists in jacks, then it would
be great to put it in there as well.



Tom has already checked in the testcase, on Robin's behalf,
into Jacks. IMHO, it doesn't make sense to repeat the testcase
in the libjava testsuite.



OK, fair enough.

It might be better to just import Jacks lock-stock-and-barrel
into the libjava testsuite (as is done for GNU Classpath now).



Yeah, this would certainly get more people running it. However, it does mean having another upstream merge to worry about. Perhaps its not a big deal for jacks, though - it doesn't change as rapidly as classpath does.

Bryce

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]