This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix PR23230 - wrong code generated in inner class


Robin Green wrote:

Jacks is most likely not the place for such a testcase - AFAICT, they
only check for compilation success, error or warning.



That's not the case. There are runtime tests as well. It is a JLS test not a
test of any specific API, so it should go in Jacks, I think - but I will
double-check on that when I submit it.



Regression tests for gcj PRs should go in libjava/testsuite, so please include the regression test when you check in your patch. Tests that are actually in the gcc tree are more likely to get run by "random gcc hackers", so its good to have as many tests in there as possible.


Of course, if no test for this currently exists in jacks, then it would be great to put it in there as well.

Bryce


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]