This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix c++/23307, ICE on invalid

From: Nathan Sidwell <nathan at codesourcery dot com>
To: Richard Guenther <rguenther at suse dot de>
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 10 Aug 2005 11:00:56 +0100
Subject: Re: [PATCH] Fix c++/23307, ICE on invalid
References: <Pine.LNX.4.58.0508101041110.7825@wotan.suse.de>

Richard Guenther wrote:

This fixes the ICE by changing an gcc_assert into returning
error_mark_node.  I seriously question the use of asserts
in paths where we might deal with erroneous input.

The assert indicates that the program logic expected nothing odd there, even for incorrect source. Have you satisfied yourself that the caller of cp_parser_temnplate_id has not screwed up.

I'm nervous of turning asserts into error checks, without understanding the context :)

nathan

--
Nathan Sidwell    ::   http://www.codesourcery.com   ::     CodeSourcery LLC
nathan@codesourcery.com    ::     http://www.planetfall.pwp.blueyonder.co.uk

Follow-Ups:
- Re: [PATCH] Fix c++/23307, ICE on invalid
  - From: Richard Guenther

References:
- [PATCH] Fix c++/23307, ICE on invalid
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]