This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix i?86 libffi with -fstack-protector
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 9 Aug 2005 13:22:34 -0700
- Subject: Re: [PATCH] Fix i?86 libffi with -fstack-protector
- References: <20050809162526.GB30077@devserv.devel.redhat.com>
On Tue, Aug 09, 2005 at 12:25:26PM -0400, Jakub Jelinek wrote:
> +#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 1)
> +# define hidden __attribute__ ((visibility ("hidden")))
> +#else
> +# define hidden
> +#endif
You need to work harder at determining whether visibility
works, do you not? And anyway, this is generally useful,
so I'd prefer to see it defined in fficonfig.h or the like.
The rest of the patch looks reasonable.
r~