This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix i?86 libffi with -fstack-protector


On Tue, Aug 09, 2005 at 12:25:26PM -0400, Jakub Jelinek wrote:
> +#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 1)
> +# define hidden __attribute__ ((visibility ("hidden")))
> +#else
> +# define hidden
> +#endif

You need to work harder at determining whether visibility
works, do you not?  And anyway, this is generally useful,
so I'd prefer to see it defined in fficonfig.h or the like.

The rest of the patch looks reasonable.


r~


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]