This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, fortran] PR21432 - allow non-standard PRINT namelist-ping
- From: FX Coudert <fxcoudert at gmail dot com>
- To: gfortran <fortran at gcc dot gnu dot org>, Paul Thomas <paulthomas2 at wanadoo dot fr>
- Cc: joe at confucius dot gnacademy dot org, patch <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 09 Aug 2005 17:02:04 +0200
- Subject: Re: [Patch, fortran] PR21432 - allow non-standard PRINT namelist-ping
Good to go, provided you change the following points:
* At the end of the patch,
+ if (k == M_WRITE)
+ goto syntax;
+
+
if (k == M_WRITE)
goto syntax;
This duplicates the (k == M_WRITE) test. Probably a copy-paste error.
* The testcase you gave in the first mail
(http://gcc.gnu.org/ml/fortran/2005-08/msg00069.html) is OK, but it
needs more than a { dg-do compile }. Add a dg-warning to check that the
good warning is emitted (since testcases are compiled with -pedantic
unless explicitly told no to).
FX
PS for Thomas: i'll be around all evening, so if you have any questions
about one of my patches please ask (IRC or phone).