This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Decompose gimplify_expr


Hello,

> >        * tree-gimple.h (gimple_predicate, rhs_predicate_for):  
> >Removed.
> >        (is_gimple_rhs_for): Declare.
> >        (enum fallback_t, gimplify_expr): Removed.
> >        (gimplify_to_void, gimplify_rhs_to_operand,  
> >gimplify_to_operand,
> >        gimplify_to_call_addr, gimplify_to_rhs,
> >        gimplify_to_assignment_rhs, gimplify_to_addressable,
> >        gimplify_to_lhs, gimplify_to_min_lval, gimplify_to_condexpr,
> >        gimplify_to_asm_val): Declare.
> [and lots of other subsequent changes]
> 
> This patch is technically OK.  However, I think it's probably not  
> suitable for stage 3, at least not without Mark's approval.

I feared so (and I won't pretend, I cannot claim the patch to be
especially well tested or guarantee it has no potential to cause
problems).  Not including it to mainline will make maintaining
of the gimplification improvements branch more difficult, but I will
have to cope somehow.  Anyway, thanks for looking at the patch.

Zdenek

> :REVIEWURL http://gcc.gnu.org/ml/gcc-patches/2005-07/msg01525.html :



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]